Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-designed NotFoundPage #77

Merged
merged 6 commits into from
May 17, 2020
Merged

Re-designed NotFoundPage #77

merged 6 commits into from
May 17, 2020

Conversation

kylerwsm
Copy link
Contributor

@kylerwsm kylerwsm commented May 13, 2020 •
edited
Loading

Problem

Re-designed the not-found-page with a mobile-first approach.

Improvements:

  • Some Eslint changes.

Before & After Screenshots

AFTER:
Desktop view, iPhone 8, iPhone 11.

Edit

  • Improved how transition page looks on shorter device (like mobile landscape view) by adding a bottom margin.

@kylerwsm kylerwsm changed the title Re-designed Not-Found-Page Re-designed NotFoundPage May 13, 2020
@kylerwsm kylerwsm marked this pull request as ready for review May 13, 2020 18:56
@kylerwsm kylerwsm requested review from liangyuanruo and yong-jie May 13, 2020 18:56
liangyuanruo
liangyuanruo approved these changes May 16, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor points made, lgtm otherwise!

@kylerwsm kylerwsm merged commit d9cb3eb into develop May 17, 2020
@kylerwsm kylerwsm deleted the not-found-page branch May 17, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo approved these changes

@yong-jie yong-jie Awaiting requested review from yong-jie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylerwsm @liangyuanruo