Godirectory #813
Merged
Godirectory #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add GET endpoint for /api/directory/search - requires query, order, limit, offset and isEmail - decision to search by email or text is done in UrlRepository - to be done: use mappers - to be done: change hardcoded sql variables and sql query checkers - to be done: include user guard for route - to be done: isolate filter checkers into helper functions
- add directory ui - add directory redirection - add actions and reducers for directory - remove userid that was previously added to urltypes - refactor endpoint
- include individual email in search results
- add mini go logo for mobile version - ensure directory to redirect back to itself on refresh - stop pagination row and sort panel from intersecting - fix svg resizing - refactor domain validation
- expand filter button to cover square area - replace go logo with mini version for mobile mode - clip shorturl in mobile panel for directory
- change the jsdoc for rawdirectoryinput
LoneRifle
previously requested changes
Oct 28, 2020
- refactor code for redirection to directory page from login page - remove the new email validation and use the old validation - replace lengthy arguments with directoryquerycondition - make isfile condition explicit - refactor rawdirectorysearch - add noopener and noreferrer to window open and anchor tag - remove semicolon for both directory and search headers - add test for directorycontroller - add test for directorysearchservice - add test for urlrepository
yong-jie
reviewed
Oct 29, 2020
yong-jie
reviewed
Oct 29, 2020
- track ga event and sentry event for directory search for both success and error case - track ga event and pageview when entering into directory page - provide redirection to directory page in error message on link creation modal
- add new reset result state and action in redux - reset to initial result state when toggle between keyword and email in directory - add new svg to announcement modal - add line break functionality to announcement message
yong-jie
reviewed
Nov 2, 2020
LoneRifle
reviewed
Nov 3, 2020
yong-jie
reviewed
Nov 3, 2020
src/client/components/widgets/GoDirectoryInput/SortDrawer/index.tsx
Outdated
Show resolved
Hide resolved
yong-jie
reviewed
Nov 3, 2020
yong-jie
reviewed
Nov 3, 2020
yong-jie
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GoDirectory allows link owners to search for the ownership of other gogovsg shortlinks
Closes #672
Closes #816
Closes #815
Closes #828
Solution
New endpoint (/directory) to search in the directory page
new/affected folders
New directory search dashboard
new/affected folders
Change header for directory page and user page
new/affected folders
Ensure directory page will redirect back to itself
new/affected folders
Ensure pagination row and sort panel will not intersect
new/affected folders
Other improvements
Screenshots
AFTER:
GoDirectory desktop default
GoDirectory desktop keyword search
GoDirectory desktop email search
GoDirectory desktop sort panel and filter panel
GoDirectory mobile default
GoDirectory mobile filter panel
GoDirectory mobile sort panel
GoDirectory mobile result panel
User page redirection in error message on link creation url
New announcement modal
