feat: fixed banner #822
Merged
feat: fixed banner #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix banner after scrolling past mast - stop text from overflowing in drawer
LoneRifle
reviewed
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #802
Solution
Add an event listener to the page to track the scroll for Y-axis. It will fix the banner's position after scrolling past the mast
Bug Fixes:
Before & After Screenshots
BEFORE:
Desktop banner at the top
Desktop banner when user scrolls to bottom
Mobile banner at the top
Mobile banner when user scrolls to bottom
Overflow text before
No overflow text after
