Folder restructure #890
Merged
Folder restructure #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add 6 new domain to client: user, search, login, home, directory and app - push actions, reducer and page components to respective domain folder - push the rest of folders into app - transfer ga from action to util - modify import paths according to the new layout - modify webpack favicon with updated assets path - modify client test with new updated path
- add page folder into components - move client index into app - modify webpack config src directory to new app path - rename godirectoryinput as directoryinput - move gosearchinput into components as it is shared - add go logo graphic folder into assets
|
Looking at the screenshots, could we also introduce a component folder in each module? |
- add components folder into directory, user, search, login and home
|
ok to merge if @yong-jie is agreeable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To improve the current folder structure, we can switch to a domain driven module structure for frontend folders
Closes #871
Solution
Separate the folders into 6 main domains: app, directory, home, login, search, user
No Code Changes besides changing import paths and re-naming of some files
Compiles nicely
AFTER:
new client folder structure
new user folder
new search folder
new login folder
new home folder
new directory folder
new app folder
