Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): remove search #902

Merged
merged 1 commit into from
Nov 13, 2020
Merged

fix(search): remove search #902

merged 1 commit into from
Nov 13, 2020

Conversation

LoneRifle
Copy link
Contributor

@LoneRifle LoneRifle commented Nov 12, 2020

Problem

GoSearch has proven to be a liability. Its effectiveness for discovery
is limited, and it has allowed determined public members to identify
links that may not have been intended for public consumption.

Closes #901

Solution

Remove both endpoint and frontend, with codebase removal at a later
point

GoSearch has proven to be a liability. Its effectiveness for discovery
is limited, and it has allowed determined public members to identify
links that may not have been intended for public consumption.

Remove both endpoint and frontend, with codebase removal at a later
point
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoneRifle LoneRifle merged commit d2cb0a9 into develop Nov 13, 2020
@LoneRifle LoneRifle deleted the fix/search/remove branch November 13, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate /#/search to avoid links from being searchable
2 participants