Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(directory): redirect with exact changes in query #915

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

Oxiang
Copy link
Contributor

@Oxiang Oxiang commented Nov 17, 2020

Problem

The directory page's query string display the entire query parameter.

Solution

Change the query string to display the exact changes

When the link is shared to someone else, the other party will have an easier time identifying the search query and the relevant filters/sort that was applied.

This will be much harder to do when the entire query parameter is stuck onto the query string.

Before & After Screenshots

BEFORE:
With query as 'test' and select 'link'
Screenshot 2020-11-17 at 9 19 45 AM

AFTER:
With query as 'test' and select 'link'
Screenshot 2020-11-17 at 9 18 33 AM

- change query string to reflect exact changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oxiang could you elaborate further on what are the differences between the old and new UX, if a user were to share the link with someone else?

@LoneRifle
Copy link
Contributor

@liangyuanruo it's one of conciseness - similar to the problem you described in #323

Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, merge when ready

@Oxiang Oxiang merged commit 0b7d3a6 into develop Nov 23, 2020
@Oxiang Oxiang deleted the directory-url branch November 23, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants