refactor(login): refactor login page #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change index, textbutton and loginform to tsx files - add explicit types for login form variants - change from higher order connect to redux hooks
LoneRifle
requested changes
Nov 19, 2020
LoneRifle
approved these changes
Nov 24, 2020
Comment on lines
+106
to
+117
| const emailValidator = useSelector( | ||
| (state: GoGovReduxState) => state.login.emailValidator | ||
| ) | ||
| const isLoggedIn = useSelector( | ||
| (state: GoGovReduxState) => state.login.isLoggedIn | ||
| ) | ||
| const email = useSelector( | ||
| (state: GoGovReduxState) => state.login.email | ||
| ) | ||
| const variant: VariantType = useSelector( | ||
| (state: GoGovReduxState) => state.login.formVariant | ||
| ) |
There was a problem hiding this comment.
Possible to do something like...
Suggested change
| const emailValidator = useSelector( | |
| (state: GoGovReduxState) => state.login.emailValidator | |
| ) | |
| const isLoggedIn = useSelector( | |
| (state: GoGovReduxState) => state.login.isLoggedIn | |
| ) | |
| const email = useSelector( | |
| (state: GoGovReduxState) => state.login.email | |
| ) | |
| const variant: VariantType = useSelector( | |
| (state: GoGovReduxState) => state.login.formVariant | |
| ) | |
| const { | |
| emailValidator, | |
| isLoggedIn, | |
| email, | |
| formVariant: variant, | |
| } = useSelector( | |
| (state: GoGovReduxState) => state.login | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Migrating jsx files in login folder to tsx files
Solution