-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home page tweaks #92
Home page tweaks #92
Conversation
65af01f
to
d8a0a5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments. At the same time, given that we have quite a lot of graphical assets now, what are your opinions on encapsulating assets into the relevant components?
I think its a good idea since some of the component files are getting rather long |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. But I think there are some changes to be done for the font sizes after the theme changes, such as the sign-in text (before, after) and the footer. Might be good to run through the rest of the pages as well to see if everything looks fine.
And thanks for working on this, it's really tedious work!
Resolved the sign-in text issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Problem
The home page implementation differs from the current design.
Closes [#89]
Solution
The home page has been tweaked to match the design (other than file upload related elements).
Improvements
Analytics icon should load correctly now
Before & After Screenshots
BEFORE:
PC:
Image 1
Samsung Note 9:
Image 1
AFTER:
PC:
Image 1
Phone X (Simulated):
Image 1
Image 2
iPad Pro (Simulated):
Image 1
Samsung Note 9:
Image 1