Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User refactor #928

Merged
merged 5 commits into from
Nov 30, 2020
Merged

User refactor #928

merged 5 commits into from
Nov 30, 2020

Conversation

Oxiang
Copy link
Contributor

@Oxiang Oxiang commented Nov 19, 2020

Problem

Incomplete migration of JSX files to TSX files
Lack of type declaration

Solution

  • migrate jsx files to tsx files
  • add explicit type to styles, components and methods
  • change from redux higher order connect to redux hooks
  • change proptypes to typescript
  • replace lodash and react memo with native timeout for searchinput
  • move formstartardorment to new file

@Oxiang
refactor(user): refactor user page
340c969 
- convert jsx files to tsx files
- change from higher order conenct to redux hooks
- assign types to function component, style and methods
- replace proptypes with typescript
@Oxiang
refactor(user): refactor searchinput
7d188eb 
- replace lodash and react memo with native timeout for searchinput
- remove commented code
- previous commit move formstartardorment to new file
liangyuanruo
liangyuanruo previously requested changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the code quality improvements; i have some clarifications which hopefully you're able to help to address.

@Oxiang
refactor(user): remove and separate
34bce5b 
- remove null type
- separate styling for formstartadorment
- remove applyleftmargin prop argument
- change onclick type to return void
- shift default values away from default prop
@Oxiang Oxiang requested a review from liangyuanruo November 24, 2020 02:47
@Oxiang Oxiang requested a review from liangyuanruo November 24, 2020 07:36
@yong-jie yong-jie mentioned this pull request Nov 26, 2020
Closed
@Oxiang
refactor(user): createlinkform
b6512d0 
- shift gaevent from createlinform to actions
- add new redux state, types and actions for file and url upload state
- switch to hooks for checking upload state
@Oxiang Oxiang requested a review from yong-jie November 30, 2020 03:51
@yong-jie yong-jie dismissed liangyuanruo’s stale review November 30, 2020 07:52

requested changes have been made

@yong-jie yong-jie merged commit bb0411d into develop Nov 30, 2020
@yong-jie yong-jie deleted the user-refactor branch November 30, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

@LoneRifle LoneRifle Awaiting requested review from LoneRifle

@liangyuanruo liangyuanruo Awaiting requested review from liangyuanruo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oxiang @liangyuanruo @yong-jie