Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(search): remove, no longer used #929

Merged
merged 1 commit into from
Nov 23, 2020
Merged

refactor(search): remove, no longer used #929

merged 1 commit into from
Nov 23, 2020

Conversation

LoneRifle
Copy link
Contributor

Problem and Solution

Remove all client and server parts of GoSearch, dropped in favour
of GoDirectory

Follows up on #901

@LoneRifle
Copy link
Contributor Author

@liangyuanruo could you have a look?

liangyuanruo
liangyuanruo approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; there's a small merge conflict due to a refactor i made to the redux reducers.

@LoneRifle
refactor(search): remove, no longer used
0cc432a 
Remove all client and server parts of GoSearch, dropped in favour
of GoDirectory
@LoneRifle LoneRifle force-pushed the refactor/search/remove branch from 2f8e6e4 to 0cc432a Compare November 23, 2020 05:02
@LoneRifle LoneRifle merged commit 9ad5161 into develop Nov 23, 2020
@LoneRifle LoneRifle deleted the refactor/search/remove branch November 23, 2020 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoneRifle @liangyuanruo