Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(redux): move creation of the Redux store singleton into its own file #939

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

liangyuanruo
Copy link
Contributor

@liangyuanruo liangyuanruo commented Nov 23, 2020

Following the Redux style guide, this PR helps to make clear the singleton initialization of the Redux store by placing its creation into its own file and decoupling it from the creation of the React <Root /> component.

Improvements:

  • Greater clarity of Redux store creation
  • Greater awareness of the use of the root reducer in Redux

@liangyuanruo liangyuanruo changed the title refactor(redux): move Redux store singleton into its own file refactor(redux): move creation of the Redux store singleton into its own file Nov 23, 2020
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liangyuanruo liangyuanruo merged commit c6ba4fb into develop Nov 23, 2020
@liangyuanruo liangyuanruo deleted the refactor/store branch November 23, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants