Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests on redirect middleware #94

Merged
merged 4 commits into from
May 19, 2020
Merged

Conversation

JasonChong96
Copy link
Contributor

@JasonChong96 JasonChong96 commented May 19, 2020

Problem

With the addition of coveralls, we're able to easily identify untested branches. There were untested branches in the redirect middleware arising from the addition of transition pages.

Solution

Add tests with differing results from cookie reducer and user agent string.

Improvements:

  • Backend test coverage +1% 🎉
  • Resolve uncaught promise rejections in redirect.ts

@JasonChong96 JasonChong96 merged commit c1bdb7f into develop May 19, 2020
@JasonChong96 JasonChong96 deleted the additional-tests branch May 22, 2020 10:12
@LoneRifle LoneRifle linked an issue Aug 26, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand test coverage for RedirectController
2 participants