Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor data representation to add unique identifier #950

Merged
merged 2 commits into from
Nov 24, 2020
Merged

fix: refactor data representation to add unique identifier #950

merged 2 commits into from
Nov 24, 2020

Conversation

liangyuanruo
Copy link
Contributor

Problem

Closes #948

Solution

Refactor the data representation to have a unique id key for each column.

yong-jie
yong-jie approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yong-jie yong-jie merged commit 130f611 into develop Nov 24, 2020
@yong-jie yong-jie deleted the fix/key-prop branch November 24, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address missing key prop in FeatureListSliver component
2 participants
@liangyuanruo @yong-jie