Server side implementation of file uploading feature #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyuanruo
requested changes
May 19, 2020
liangyuanruo
requested changes
May 22, 2020
liangyuanruo
previously approved these changes
May 26, 2020
* Move otp-related endpoints in login to Joi * Add types to the shortUrl destructured from params in redirect. The reason I opted not to move any of the validation in this function into Joi was because it has its own set of behaviours depending on each validation failure, such as rendering 404 pages etc. This is not something that can be done by a Joi validator. * Remove obsolete tests * Minor code cleanup for Joi validation (#132) * Name a new VerifyOtpRequest type after the API * Move types into /types folder * Rename transitionPage.ts from camelCase to kebab-case * Remove duplicate type file Co-authored-by: Yuan Ruo <liangyuanruo@gmail.com>
JasonChong96
reviewed
Jun 1, 2020
kylerwsm
approved these changes
Jun 1, 2020
This was referenced Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Under the premise that url objects cannot be deleted, the
creation of a link + upload file to s3step cannot be atomic when it is done client side.Solution
This PR modifies the shortUrl creation endpoint to accept files as an optional parameter that enables the file-uploading process to S3.
Additional Changes
This PR also introduces Joi validation to protect the endpoint handlers.
Environment Variables
These new env vars will be introduced in docker-compose.yml to allow aws-sdk to interface with S3. They are necessary for development only when working with file links. These env vars will become obsolete once #117 is complete.