Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backgroundtype as optional #978

Merged
merged 1 commit into from
Nov 26, 2020
Merged

fix: backgroundtype as optional #978

merged 1 commit into from
Nov 26, 2020

Conversation

Oxiang
Copy link
Contributor

@Oxiang Oxiang commented Nov 26, 2020

Problem

Uncaught merge error that cause build to fail

During development, the login index was still in JSX, thus there was no error.
Once merge, the TSX version throws an error.

Screenshot 2020-11-26 at 3 36 48 PM

Solution

Change backgroundType as optional and have default argument of empty string

@Oxiang Oxiang requested a review from yong-jie November 26, 2020 08:26
@Oxiang Oxiang merged commit 2f9a319 into develop Nov 26, 2020
@Oxiang Oxiang deleted the bug-fix branch November 26, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants