Refactor drawer domain #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moved state tracking of edited longURl into LongUrlEditor component instead of redux
Throughout all uses of ConfigOption, the title variant and title classnames follow a certain pattern. For mobile responsive fields, they start with h6 variant and use regularText CSS when in mobile view Given that this pattern has repeated for many times, move the implementation into ConfigOption's implementation and expose a boolean isMobileResponsive flag to toggle the behaviour.
liangyuanruo
reviewed
Dec 2, 2020
liangyuanruo
reviewed
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Drawer domain was implemented and migrated in a way that unnecessarily exposed a lot of implementation. There was a lot of code reimplementation that could have been abstracted for reuse.
Partially fixes #970
Solution
Improvements:
Extract LinkStateText, LinkOwnershipField, LongUrlEditor, FileEditor into their own components.
Move ConfigOption into DownloadButton's implementation
Enable reuse of regularText CSS by moving it into ConfigOption
Move state management into the smallest component subset, which fixed bug File error message not cleared when navigating to other file links in drawer #970