feat: allow tree shaking on design-system, use vite to build output #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since root package.json is now type: module, .js files are now treated as ESM files... which storybook does not support. See storybookjs/storybook#11587 (comment)
✅ Deploy Preview for objective-bell-0ffbfb canceled.
|
JasonChong96
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR changes the bundler to
vite(which still uses rollup under the hood, just much faster) and adds the necessary config to make the library tree-shakeable (tested only with CRA4, CRA5 has wonky behaviour with ESModules...).Before (no tree shake):
After (tree shake):
After importing one additional component
Not fully tested yet, may not 100% work with CRA5, NextJS, etc. But for the most part it should be fine~
Loads fine with CRA4 app:
