feat: remove paramsSerializer as it's included by default in the new …

…version of axios
opengovsg · Jan 9, 2024 · 2f4249f · 2f4249f
1 parent 609c432
commit 2f4249f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/src/MyInfoGovClient.class.ts b/src/MyInfoGovClient.class.ts
@@ -215,7 +215,6 @@ export class MyInfoGovClient {
       response = await axios.get(url, {
         headers,
         params,
-        paramsSerializer: qs.stringify,
       })
     } catch (err: unknown) {
       throw new MyInfoResponseError(err)

diff --git a/test/unit/MyInfoGovClient.test.ts b/test/unit/MyInfoGovClient.test.ts
@@ -397,7 +397,6 @@ describe('MyInfoGovClient', () => {
 
       expect(MockAxios.get).toHaveBeenCalledWith(expectedUrl, {
         params: expectedQueryParamsObj,
-        paramsSerializer: expect.any(Function),
         headers: {
           'Cache-Control': 'no-cache',
           Authorization: expect.any(String),
@@ -431,7 +430,6 @@ describe('MyInfoGovClient', () => {
 
       expect(MockAxios.get).toHaveBeenCalledWith(expectedUrl, {
         params: expectedQueryParamsObj,
-        paramsSerializer: expect.any(Function),
         headers: {
           'Cache-Control': 'no-cache',
           Authorization: expect.any(String),
@@ -567,7 +565,6 @@ describe('MyInfoGovClient', () => {
 
       expect(MockAxios.get).toHaveBeenCalledWith(expectedUrl, {
         params: expectedQueryParamsObj,
-        paramsSerializer: expect.any(Function),
         headers: {
           'Cache-Control': 'no-cache',
           Authorization: expect.any(String),
@@ -626,7 +623,6 @@ describe('MyInfoGovClient', () => {
 
       expect(MockAxios.get).toHaveBeenCalledWith(expectedUrl, {
         params: expectedQueryParamsObj,
-        paramsSerializer: expect.any(Function),
         headers: {
           'Cache-Control': 'no-cache',
           Authorization: expect.any(String),