Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor examples to use redirect instead of callback #56

Merged
merged 1 commit into from
May 24, 2023

Conversation

raynerljm
Copy link
Contributor

Problem

Non-standard naming (we use callback and redirect interchangeably in our dev docs/README/SDKs, etc.) In an effort to standardize the term, this PR changes all the examples to use redirect instead of callback.

This is done together with standardizing the dev docs and the developer portal

How did you solve the problem?

For Express example:

  • Change redirectUri definition in SgidClient to be /redirect instead of /callback
  • Change the endpoint to /redirect from /callback

For Next.js CSR example:

  • Change redirectUri definition in SgidClient to be /redirect instead of /callback
  • Change the API route handler file name to redirect.ts from callback.ts

@raynerljm raynerljm requested a review from kwajiehao May 24, 2023 10:17
Copy link
Contributor

@kwajiehao kwajiehao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kwajiehao added a commit to opengovsg/sgid-client-python that referenced this pull request May 24, 2023
@raynerljm raynerljm merged commit 06385d8 into develop May 24, 2023
@raynerljm raynerljm deleted the refactor/callback-to-redirect branch May 24, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants