Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In a recent VAPT on
care360
, it was discovered that an open redirect is still possible by using an undocumented feature (interception routes interpolation) (issue labelled asGTA-55-008
).Approach
In this version bump, I have ported the check for interception routes into the validation logic.
This should block the the undocumented feature.
In the next version bump, a strict character whitelist will be enforced by default, with an option to override it.
Risk
This will break existing routes that contain
(.) or (..) or (...) or (..)(..)
.Testing
The fix can be verified simply by visiting the links below and checking if the open redirect can still be triggered.
Email:
any@open.gov.sg
OTP:
123123
[v1.2.10 open redirect poc] [deploy src]
[v1.2.11 poc no longer works] [deploy src]
VAPT vendor says [link]