Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfxcom] Depends on Full JRE #3424

Closed
svilenvul opened this issue Mar 30, 2018 · 4 comments
Closed

[rfxcom] Depends on Full JRE #3424

svilenvul opened this issue Mar 30, 2018 · 4 comments

Comments

@svilenvul
Copy link

Looking at the report generated by openhab/static-code-analysis#283, I see that several packages in rfxcom binding depend on Full JRE:

  • org.openhab.binding.rfxcom.handler depends on javax.xml.bind (Full JRE)
  • org.openhab.binding.rfxcom.internal.connector depends on javax.xml.bind (Full JRE)
  • org.openhab.binding.rfxcom.internal.messages depends on javax.xml.bind (Full JRE)

This is a violation of C.1 in the openHAB coding guidelines https://docs.openhab.org/developers/development/guidelines.html#c-language-levels-and-libraries.

It will be good if we can refactor it, so the bundle remains restricted to Compact Profile 2, or if it is not possible document that the binding is an exception.

@martinvw
Copy link
Member

Checking the code here looks hopeful it seems to be caused by DatatypeConverter I believe printf or String.format can do something similar

@martinvw
Copy link
Member

@kaikreuzer the code for the functionality (convert byte arrays to a hexadecimal string) we use is non trivial so ideal I would add it somewhere in ESH, what do you think that a proper place would be in esh or can we add commons codec as a dependency for ESH...

@kaikreuzer
Copy link
Member

convert byte arrays to a hexadecimal string

Sounds just like this, doesn't it?

martinvw added a commit to martinvw/openhab2-addons that referenced this issue Mar 30, 2018
Fixes: openhab#3424

Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>
martinvw added a commit to martinvw/openhab2-addons that referenced this issue Mar 30, 2018
Fixes: openhab#3424

Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>
@martinvw
Copy link
Member

@kaikreuzer I needed a small extension and some time to dust of my smarthome checkout :-)

eclipse-archived/smarthome#5331

martinvw added a commit to martinvw/openhab2-addons that referenced this issue Apr 2, 2018
Fixes: openhab#3424

Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants