Update lastnpe EEA to 2.4.0

[lsiepel]

Resolves: #10396

The reason is that the new version fixes that Optional.orElse can return null values (based on the parameter).
There is quite some code using Optional.orElse expecting the result to be non-null.

In most cases i wrapped the optional in Objects.requireNonNull(..) and in some cases i removed the optional.

At time of writing bindings A-D have been adjusted and i like to get some feedback before proceeding to fix all.
Edit: Moved on to bindings A - K

JFTR: to be merged after 4.2 release as i cannot test all bindings.

[J-N-K]

The problem is that we can't do proper null annotations with EEA. Unfortunately there is no will on Eclipse side to fix that. We would need something like "non-null if argument is non-null". This also applies to Map.compute and similar methods.

[lsiepel]

The problem is that we can't do proper null annotations with EEA. Unfortunately there is no will on Eclipse side to fix that. We would need something like "non-null if argument is non-null". This also applies to Map.compute and similar methods.

Is there some kind of link to that discussion? And more important do you have some thoughts on how to proceed in relation to this PR?

[J-N-K]

lastnpe/eclipse-null-eea-augments#116 and linked issues

https://bugs.eclipse.org/bugs/show_bug.cgi?id=575822

[morph166955]

I can't validate this any time soon for the AndroidTV/PhillipsTV bit. Is this a Java 17 update or would this still be backwards compatible to Java 11? I'm about to kill off the 3.x compatibility but I haven't yet so I'm trying to keep that in mind still.

[lsiepel]

I can't validate this any time soon for the AndroidTV/PhillipsTV bit. Is this a Java 17 update or would this still be backwards compatible to Java 11? I'm about to kill off the 3.x compatibility but I haven't yet so I'm trying to keep that in mind still.

As far as i know this should be java 11 compatible. Maybe 4.2 is a good point to move on anyway.

[weymann]

Fine for sensorcommunity

[wborn]

Thanks a lot! 👍

[bern77]

LGTM for helioseasycontrol

[lsiepel]

@openhab/add-ons-maintainers now 4.3 development is started, would be nice to have this merged sooner then later.

[wborn]

Looks like some new code got added that no longer compiles with the newer EEAs.
Can you update that too @lsiepel? After that we can merge the PR.

[lsiepel]

@openhab/add-ons-maintainers ping