-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt.homeassistant] Update Jinjava to 2.7.3 #17412
[mqtt.homeassistant] Update Jinjava to 2.7.3 #17412
Conversation
Signed-off-by: Cody Cutrer <cody@cutrer.us>
[WARNING] Error: |
Where deos it get that artifact from? Should the osgified file be uploaded somewhere? |
I have no idea. I just kind of assumed a nightly build would handle it. But it's been two nights now. @J-N-K? |
@kaikreuzer could you please upload the latest version? Thanks! |
This should work automatically once the build is triggered. |
Do I get it correctly, https://ci.openhab.org/job/openhab-osgiify/ should upload the artifacts? @J-N-K it seems that build 36 did not properly store to Artifactory. |
@wborn thanks, seems you fixed it. For future changes, do you need to trigger that ci build manually (liike a release/milestone), or should this build and upload ci trigger automatically after merge? |
It's a manual build. |
I upgraded the Jenkins Artifactory plugin to fix it. I downgraded it earlier to see if it would fix the other issue but it didn't help. When I find some time I'll try to replace it with the Artifactory Maven plugin which can also be used to upload artifacts in GitHub Actions builds. |
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Almost there. Some dependency’s are missing |
Omg, there it is! 2.7.3 added the following new dependencies:
Thank you for pointing it out! Now to figure out how to add dependencies... |
Signed-off-by: Cody Cutrer <cody@cutrer.us>
openhab/openhab-osgiify#53 needs merged and pushed to the openhab repo first. After that, I ran a full verify build including itests for MQTT and Jinja Transformation locally, and everything passed. 🤞 |
Woohoo! Build passed! |
* [mqtt.homeassistant] Update Jinjava to 2.7.3 Signed-off-by: Cody Cutrer <cody@cutrer.us>
* [mqtt.homeassistant] Update Jinjava to 2.7.3 Signed-off-by: Cody Cutrer <cody@cutrer.us>
Dependent on openhab/openhab-osgiify#51.
Closes #15145