Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pihole] Add channels for gravity #17413

Merged
merged 4 commits into from
Sep 15, 2024
Merged

[pihole] Add channels for gravity #17413

merged 4 commits into from
Sep 15, 2024

Conversation

magx2
Copy link
Contributor

@magx2 magx2 commented Sep 12, 2024

Signed-off-by: Martin Grześlowski <martin.grzeslowski@gmail.com>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/pi-hole-binding-add-new-feature-gravity-last-updated/158331/6

Signed-off-by: Martin Grześlowski <martin.grzeslowski@gmail.com>
Signed-off-by: Martin Grześlowski <martin.grzeslowski@gmail.com>
@lsiepel lsiepel changed the title Add channels for gravity [pihole] Add channels for gravity Sep 12, 2024
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Sep 12, 2024
@lsiepel lsiepel self-requested a review September 12, 2024 20:51
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise LGTM

Signed-off-by: Martin Grześlowski <martin.grzeslowski@gmail.com>
@magx2 magx2 requested a review from lsiepel September 15, 2024 10:28
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@lsiepel lsiepel merged commit 104f328 into openhab:main Sep 15, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Sep 15, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants