Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[siemensrds] Fix setting of target temperature #17697

Merged
merged 2 commits into from
Nov 4, 2024
Merged

[siemensrds] Fix setting of target temperature #17697

merged 2 commits into from
Nov 4, 2024

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Nov 4, 2024 •
edited
Loading

Resolves #17695

Signed-off-by: AndrewFG software@whitebear.ch

@andrewfg
[siemensrds] Fix setting of target temperature
cda47df 
Signed-off-by: AndrewFG <software@whitebear.ch>
@andrewfg andrewfg added the bug An unexpected problem or unintended behavior of an add-on label Nov 4, 2024
@andrewfg andrewfg self-assigned this Nov 4, 2024
@andrewfg andrewfg requested a review from a team November 4, 2024 13:15
@andrewfg
Copy link
Contributor Author

andrewfg commented Nov 4, 2024

Can I support you somehow fixing this issue?

@oxigen-dev I fixed your issue; you can download the Jar for testing org.openhab.binding.siemensrds-4.3.0-SNAPSHOT.jar.zip

jlaur
jlaur approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One very minor comment to consider. Should we await user tests before merging?

...hab.binding.siemensrds/src/main/java/org/openhab/binding/siemensrds/internal/RdsHandler.java Outdated Show resolved Hide resolved
@andrewfg
adopt reviewer suggestion
83f35d1 
Signed-off-by: AndrewFG <software@whitebear.ch>
@andrewfg
Copy link
Contributor Author

andrewfg commented Nov 4, 2024

Should we await user tests before merging?

@jlaur not really necessary as I have tested on my own system. I posted the Jar for the OP to use if he doesn't want to wait for the new release or milestone.

@andrewfg andrewfg requested a review from jlaur November 4, 2024 15:13
@jlaur jlaur merged commit 5d20cba into openhab:main Nov 4, 2024
5 checks passed
@jlaur jlaur added this to the 4.3 milestone Nov 4, 2024
@jlaur
Copy link
Contributor

jlaur commented Nov 4, 2024

I posted the Jar for the OP to use if he doesn't want to wait for the new release or milestone.

The fix seems quite safe, so we can also backport to 4.2.x?

@andrewfg
Copy link
Contributor Author

andrewfg commented Nov 4, 2024

we can also backport to 4.2.x?

Sure.

jlaur pushed a commit that referenced this pull request Nov 4, 2024
@andrewfg @jlaur
[siemensrds] Fix setting of target temperature (#17697)
b897c95 
Signed-off-by: AndrewFG <software@whitebear.ch>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Nov 4, 2024
@oxigen-dev
Copy link

Can I support you somehow fixing this issue?

@oxigen-dev I fixed your issue; you can download the Jar for testing org.openhab.binding.siemensrds-4.3.0-SNAPSHOT.jar.zip

Thanks for the very quick support, I can confirm it is working again!

@andrewfg andrewfg deleted the siemens-rds branch November 6, 2024 15:44
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
@andrewfg @KaaNee
[siemensrds] Fix setting of target temperature (openhab#17697)
aed8022 
Signed-off-by: AndrewFG <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur Awaiting requested review from jlaur

Assignees

@andrewfg andrewfg

Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[siemensrds] Setting target temperature doesn't work anymore
3 participants
@andrewfg @jlaur @oxigen-dev