Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameter sendFrequency #4338

Closed
7 tasks done
mueller-ma opened this issue Aug 7, 2024 · 6 comments
Closed
7 tasks done

Remove parameter sendFrequency #4338

mueller-ma opened this issue Aug 7, 2024 · 6 comments
Labels

Comments

@mueller-ma
Copy link
Member

mueller-ma commented Aug 7, 2024

Is your feature request related to a problem? Please describe.

This parameter has been used in Classic UI which isn't available anymore. I also checked the Android app and it isn't used there.

It may wonder people what the parameter does when they read about it in the docs.

Also see #3430 (comment)

Describe the solution you'd like

I think we should remove it at all.

Additional context

Coordination between maintainers

Notify maintainers of other UIs:
@openhab/webui-maintainers
@openhab/android-maintainers
@openhab/ios-maintainers

Checklist for implementation:

@timbms
Copy link

timbms commented Aug 9, 2024

Not in use in iOS app either.

@lolodomo
Copy link
Contributor

lolodomo commented Aug 9, 2024

In Basic UI, the parameter is read but then unused for the colorpicker widget.
Never used for the slider widget. If I correctly remember, this was cleaned in 4.2 when I fixed the slider widget behaviour.

I will submit a Basic UI PR to remove few useless lines for colorpicker => edit: done

lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Aug 9, 2024
Note that %frequency% does not exist in colorpicker snippet.

Related to openhab/openhab-core#4338

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer pushed a commit to openhab/openhab-webui that referenced this issue Aug 11, 2024
#2699)

Note that %frequency% does not exist in colorpicker snippet.

Related to openhab/openhab-core#4338

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor

Basic UI is now ok.
Next step would be sitemap generator in Main UI.

@lolodomo
Copy link
Contributor

No, a little more. I will prepare a PR during the week.

lolodomo added a commit to lolodomo/openhab-core that referenced this issue Aug 14, 2024
Related to openhab#4338

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer pushed a commit that referenced this issue Sep 7, 2024
…ts (#4347)

Related to #4338

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor

lolodomo commented Sep 7, 2024

This feature can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants