Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to JmDNS 3.5.12 #4337

Merged
merged 6 commits into from
Sep 7, 2024
Merged

Upgrade to JmDNS 3.5.12 #4337

merged 6 commits into from
Sep 7, 2024

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer commented Aug 7, 2024 •
edited
Loading

@kaikreuzer
Upgrade to JmDNS 3.5.11
84fae5c 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer requested a review from a team as a code owner August 7, 2024 13:28
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Aug 7, 2024
wborn
wborn requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Karaf feature still needs to be updated.

@kaikreuzer
Copy link
Member Author

Hm, I thought I did it this time, but it is indeed missing in the commit...
Anyhow, let's wait with the merge until jmdns/jmdns#281 is clarified.

@kaikreuzer kaikreuzer marked this pull request as draft August 8, 2024 09:13
@kaikreuzer
Also update Karaf feature
213ab64 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
holgerfriedrich
holgerfriedrich requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to switch to 3.5.12?

bom/compile/pom.xml Outdated Show resolved Hide resolved
bom/runtime/pom.xml Outdated Show resolved Hide resolved
features/karaf/openhab-tp/src/main/feature/feature.xml Outdated Show resolved Hide resolved
itests/org.openhab.core.config.discovery.mdns.tests/itest.bndrun Outdated Show resolved Hide resolved
kaikreuzer and others added 4 commits August 29, 2024 22:22
@kaikreuzer @holgerfriedrich
Update itests/org.openhab.core.config.discovery.mdns.tests/itest.bndrun
5bb10a6 
Co-authored-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer @holgerfriedrich
Update features/karaf/openhab-tp/src/main/feature/feature.xml
1b3b31b 
Co-authored-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer @holgerfriedrich
Update bom/runtime/pom.xml
68e8e8a 
Co-authored-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer @holgerfriedrich
Update bom/compile/pom.xml
1257760 
Co-authored-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

Ready to switch to 3.5.12?

For sure!
But to be on the safe side, I would suggest waiting with merging it until after 4.3.0.M1.

@kaikreuzer kaikreuzer changed the title Upgrade to JmDNS 3.5.11 Upgrade to JmDNS 3.5.12 Aug 29, 2024
holgerfriedrich
holgerfriedrich approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich holgerfriedrich marked this pull request as ready for review September 6, 2024 21:17
@holgerfriedrich
Copy link
Member

@wborn I think your review comment has been addressed, can we merge?

@holgerfriedrich holgerfriedrich added the dependencies Pull requests that update a dependency file label Sep 7, 2024
wborn
wborn approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@wborn wborn merged commit b3f7103 into openhab:main Sep 7, 2024
5 checks passed
@wborn wborn added this to the 4.3 milestone Sep 7, 2024
holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this pull request Sep 8, 2024
@holgerfriedrich
Upgrade to JmDNS 3.5.12
b875ca2 
Adapt itests to core, see openhab/openhab-core#4337.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich mentioned this pull request Sep 8, 2024
Merged
wborn pushed a commit to openhab/openhab-addons that referenced this pull request Sep 8, 2024
@holgerfriedrich
Upgrade to JmDNS 3.5.12 (#17389)
52cc195 
Adapt itests to core, see openhab/openhab-core#4337.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@kaikreuzer @holgerfriedrich @wborn