Sitemap editor: Validation improvements #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2255 Bundle Size — 10.84MiB (+0.03%).f7b327d(current) vs d79efb7 main#2250(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2255 |
Baseline #2250 |
|
|---|---|---|
 Initial JS |
1.89MiB |
1.89MiB |
| Initial CSS |
576.5KiB |
576.5KiB |
 Cache Invalidation |
17.59% |
18.22% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2919(+0.17%) |
2914 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 2 changes 
2 regressions
| Current #2255 |
Baseline #2250 |
|
|---|---|---|
| JS |
9.05MiB (+0.04%) |
9.05MiB |
| CSS |
863.35KiB (+0.02%) |
863.17KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.36KiB |
1.36KiB |
| Other |
871B |
871B |
Bundle analysis report Branch mherwege:sitemap_mapping Project dashboard
Generated by RelativeCI Documentation Report issue
|
@mherwege One of the unit tests fails, can you please have a look? |
mherwege
force-pushed
the
sitemap_mapping
branch
from
0a469fa
to
a7e0ab3
Compare
It should be OK now. |
florian-h05
requested changes
Sep 12, 2024
bundles/org.openhab.ui/web/src/components/pagedesigner/sitemap/widget-details.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/config/controls/persistence-picker.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/config/controls/persistence-picker.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/config/controls/persistence-picker.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/config/controls/persistence-picker.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/config/controls/persistence-picker.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/config/controls/persistence-picker.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/components/config/controls/persistence-picker.vue
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/pages/settings/pages/sitemap/sitemap-edit.vue
Outdated
Show resolved
Hide resolved
|
@florian-h05 Thank you for the feedback. I have addressed your comments. |
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
This reverts commit 7f23b21.
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
mherwege
force-pushed
the
sitemap_mapping
branch
from
46aa1c9
to
df44071
Compare
florian-h05
approved these changes
Sep 13, 2024
bundles/org.openhab.ui/web/src/components/pagedesigner/sitemap/widget-details.vue
Outdated
Show resolved
Hide resolved
…/widget-details.vue Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2701.
This PR contains a number of sitemap validation improvements, interactive, before saving and in the DSL parser.