Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add router advertisement support for Matter #1922

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

ecdye
Copy link
Contributor

@ecdye ecdye commented Oct 23, 2024

Fixes #1919

@ecdye ecdye added the enhancement New feature or request label Oct 23, 2024
@ecdye ecdye requested a review from mstormi October 23, 2024 01:00
@ecdye ecdye changed the title Add support for route advertisments for Matter Add support for route advertisements for Matter Oct 23, 2024
mstormi
mstormi previously approved these changes Oct 23, 2024
Copy link
Contributor

@mstormi mstormi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lrabius
Copy link

lrabius commented Oct 23, 2024

On a fresh install dhcpcd won't be installed anymore, because it was replaced by NetworkManager with Raspi OS bookworm. But I don't know what happens to dhcpcd when you upgrade from an older Raspi OS.

Also it's called Router Advertisements 😉

@mstormi
Copy link
Contributor

mstormi commented Oct 23, 2024

Not sure how it all relates but dhcpcd is still part of Raspi OS/bookworm, we don't install it on top

@lrabius
Copy link

lrabius commented Oct 23, 2024 via email

@mstormi
Copy link
Contributor

mstormi commented Oct 23, 2024

Apparently so.
Ethan eventually you can remove dhcpcd remainders with this PR, too?

Fixes openhab#1919

Signed-off-by: Ethan Dye <mrtops03@gmail.com>
@ecdye ecdye changed the title Add support for route advertisements for Matter Add router advertisement support for Matter Oct 24, 2024
@ecdye ecdye requested a review from mstormi October 24, 2024 03:28
@ecdye ecdye merged commit 7d97bd8 into openhab:main Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 Route Advertisements Not Accepted
3 participants