Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix severity level #411

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Fix severity level #411

merged 1 commit into from
Apr 13, 2021

Conversation

cweitkamp
Copy link
Contributor

@cweitkamp cweitkamp commented Apr 13, 2021 •
edited
Loading

  • Fix severity level

Unfortunately I used a wrong severity level in my PR #408. This leads to a broken 0.11.0 release.

[ERROR] Failed to execute goal org.openhab.tools.sat:sat-plugin:0.11.0:checkstyle (sat-all) on project org.openhab.core.model.lazygen: Unable to execute mojo: Execution null of goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:checkstyle failed: No enum constant com.puppycrawl.tools.checkstyle.api.SeverityLevel.WARN -> [Help 1]

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

@cweitkamp
Fix severity level
3208139 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp requested a review from a team as a code owner April 13, 2021 12:15
wborn
wborn approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I also didn't notice this while reviewing. 😞
Some kind of SAT integration test might help preventing this and many other issues.

@wborn wborn merged commit ce1879b into openhab:main Apr 13, 2021
@cweitkamp cweitkamp deleted the patch-1 branch April 13, 2021 13:22
@kaikreuzer kaikreuzer added this to the 0.11.1 milestone Apr 13, 2021
@kaikreuzer
Copy link
Member

I've released 0.11.1 with this change: https://github.com/openhab/static-code-analysis/releases/tag/0.11.1

@cweitkamp
Copy link
Contributor Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cweitkamp @kaikreuzer @wborn