This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Initial config for OpenFn HAPI FHIR & OpenHIM #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first draft of adding OpenFn Microservice into instant.
What we've done so far is port our OpenFn/instant-demo example into the instant repo.
I was hoping for some guidance and opinions about how we should integrate this into instant.
This goes around what to name the folder. It's currently called
openfn
.@taylordowns2000 mentioned that adding the microservice image/app to
core
was a possibility.It appears the structure that exists (other than core) is based around use case, like "here's a pre-baked and tested setup for a certain purpose" and core handles the rest.
And since the OpenFn Microservice can be used in lots of different ways (just like OpenHIM) it's feeling a bit weird having a folder named
openfn
.So should we:
a) instead add microservice into
core
, and have another folder or change an existing one to add the specific configuration for working with HAPI FHIR via OpenHIM.b) keep microservice in it's own folder but perhaps change the name to something other than
openfn
.c) something else...
Thoughts?