ZicntrS covergroup #342
Merged
ZicntrS covergroup #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Leilani Elkaslasy <lelkaslasy@hmc.edu>
|
Please review this covergroup with somebody before reading my comments below. I think you and your reviewer will catch these. cp_mcounteren_write doesn’t specify which counter or privilege mode. However, it’s already covered in ZicntrU, so you can drop it. |
|
Done and made new pr. Everything should be good now
…On Sat, Feb 1, 2025 at 5:24 AM David Harris ***@***.***> wrote:
Please review this covergroup with somebody before reading my comments
below. I think you and your reviewer will catch these.
cp_mcounteren_write doesn’t specify which counter or privilege mode.
However, it’s already covered in ZicntrU, so you can drop it.
Cp_scounteren needss a cross with scounteren and priv_mode_s
—
Reply to this email directly, view it on GitHub
<#342 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3ZCW3MWMOJOE4YSCHA7EUD2NTDIHAVCNFSM6AAAAABSM5CODKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRYHE2TENJRGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored with @lanilei