-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not compile for any target because of unavailable SFSafariViewController #146
Comments
Using Cocoapods? Based on this SO post: https://stackoverflow.com/a/37289688/375209 Add to the end of your Podfile:
:-} |
@ened Thank you! Btw all this time I had this in my Podfile: target 'my app' do
platform :ios, '10.0'
pod 'GTMAppAuth'
... but seems like pods are special and require additional configuration. |
Either this projects platform dependency should be updated in the podspec or the code should be adapted to support both the old and new method (SFSafari.. being the new one). The method above does the first thing, but limited to your project. Probably good idea to send a PR here and fix it permanently. |
So this was a case of a newly introduced warning breaking downstream builds due to our "treat warnings as errors" flag. The code in this case was still functionally correct, but not in a way that would avoid the warning. Changing the deployment target to 9 is a valid workaround as long as you don't need to target iOS 7 or 8 (which AppAuth still supports). Another workaround is adding #158 resolves the underlying warning, and also moves "treat warnings as errors" from the Podspec to the CI spec. This way warnings will still be flagged during CI, but will avoid breaking downstream builds. |
Issue openid/AppAuth-iOS#146 Fix openid/AppAuth-iOS#158 Release in https://github.com/openid/AppAuth-iOS/releases/tag/0.91.0 > Fixes several "availability" warnings and errors. Corrects deployment targets.
On macOS 10.13.1 Beta
Xcode 9.0 (9A235)
AppAuth 0.9.1
Project does not compile because of
'SFSafariViewController' is only available on iOS 9.0 or newer
Changing target from iOS 9 to 10, or 11 does nothing.
![screen shot 2017-09-30 at 12 57 39 pm](https://user-images.githubusercontent.com/1980807/31048278-b42b1b82-a5df-11e7-8e69-f0d6456646bb.png)
Most probably the problem is in Xcode, but anyway, any hints how to fix this?
The text was updated successfully, but these errors were encountered: