Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor HAIP and add details for mdoc profile of OID4VP over the Browser API #122
base: main
Are you sure you want to change the base?
refactor HAIP and add details for mdoc profile of OID4VP over the Browser API #122
Changes from all commits
094b35b
95bcf02
2f4b2ec
77aa345
796886b
cb19041
85bef24
013c1fd
c45eb79
1465f18
02740b1
ed8a27f
4fe9fb3
aaf7d87
79514e1
1e5abe7
71de98e
680abc2
42aca21
803272d
58edeaf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we call it cryptographic holder binding in our spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-2-4.26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can keep it as cryptographic key binding. i opened a issue here: openid/OpenID4VP#369
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean with "our spec"? Definitely not in the SD-JWT, as the changelog even says
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i put the references, Jan. oid4vp and oid4vci specs use the term cryptographic holder binding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, please fix the grammar for all bullet point lists in the document and consider removing "unless specified otherwise" (I don't immediately see where we do specify it otherwise)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, the otherwise part intends to say that unless it says "the wallet must... the verifier MAY...", the requirement applies to both wallet and the verifier, which sounds kind of useful clarification?
I would like to do this in another PR, as it touches the entire document, not just the ones edited in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, understood. Then I propose to find a wording in the bullet points to call out explicitly for each point who needs to follow it.
Re the editorial stuff - fine for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the hash instead of the raw values to enable remote signature architectures to prevent the remote service to learn more than necessary about the transaction details, i.e., origin, client etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that is potentially missing in
OID4VPDCAPIHandoverInfo
is the public key of the verifier.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.