Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/op 1360 #9

Merged
merged 7 commits into from
May 17, 2023
Merged

Feature/op 1360 #9

merged 7 commits into from
May 17, 2023

Conversation

lruzicki
Copy link
Contributor

Ticket:
https://openimis.atlassian.net/browse/OP-1360

Changes:

  • changed 'core_User_Groups' to 'Core_User_Groups' due to conflict with names in Django migrations with "core.user_Groups"
  • added missing field for tblPremium

@lruzicki lruzicki requested review from delcroip, dborowiecki and a user May 16, 2023 12:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

delcroip
delcroip approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@delcroip delcroip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lruzicki can I merge it or do you want other review / change

@ghost
Copy link

ghost commented May 16, 2023

@delcroip @lruzicki
There are commits there not present in the develop branch I believe. I think they were added to the main branch as hotfix, and probably should not be added here.

@lruzicki lruzicki mentioned this pull request May 17, 2023
Merged
@lruzicki lruzicki marked this pull request as ready for review May 17, 2023 15:33
@lruzicki
Copy link
Contributor Author

@delcroip we can merge it

@delcroip delcroip merged commit 7063280 into develop May 17, 2023
@delcroip delcroip deleted the feature/OP-1360 branch May 17, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delcroip delcroip delcroip approved these changes

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lruzicki @delcroip @edarchis