Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTC-757: Clearing pagination state if entered the PaymentsPage #13

Merged
merged 2 commits into from
Mar 22, 2023
Merged

OTC-757: Clearing pagination state if entered the PaymentsPage #13

merged 2 commits into from
Mar 22, 2023

Conversation

olewandowski1
Copy link
Contributor

@olewandowski1 olewandowski1 commented Mar 22, 2023 •
edited
Loading

OTC-757

Changes:

  • Clearing pagination state if entered the PaymentsPage.
  • Implementation of the logic responsible for going back from edit form and keeping the same page which was before.

@olewandowski1 olewandowski1 marked this pull request as ready for review March 22, 2023 13:47
sniedzielski
sniedzielski approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@sniedzielski sniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @olewandowski1 . I left one optional suggestion. But this PR could be merged.

@delcroip delcroip merged commit b0dde65 into develop Mar 22, 2023
@delcroip delcroip deleted the feature/OTC-757 branch March 22, 2023 14:59
delcroip added a commit that referenced this pull request Jul 6, 2023
@delcroip @olewandowski1
@jdolkowski @dragos-dobre
MERGING RELEASE branches (#16)
ffd37d7 
* Delete package-lock.json

* Update package.json

* OP-1084: Removal of redundant imports

* OP-1084: Pagination fix in PaymentSearcher.js

* OTC-757: Clearing pagination state if entered the PaymentsPage (#13)

* OTC-757: Clearing pagination state if entered the PaymentsPage

* OTC-757: Moved moduleName to the constants

* OTC-966: make save button always visible (#12)

---------

Co-authored-by: olewandowski <olewandowski@soldevelo.com>
Co-authored-by: olewandowski1 <109145288+olewandowski1@users.noreply.github.com>
Co-authored-by: Jan <jdolkowski@soldevelo.com>
Co-authored-by: Dragos DOBRE <dragos.dobre@swisstph.ch>
dragos-dobre added a commit that referenced this pull request Sep 4, 2023
@delcroip @olewandowski1
@jdolkowski @dragos-dobre
MERGING RELEASE branches (#20)
2f10535 
* Delete package-lock.json

* Update package.json

* OP-1084: Removal of redundant imports

* OP-1084: Pagination fix in PaymentSearcher.js

* OTC-757: Clearing pagination state if entered the PaymentsPage (#13)

* OTC-757: Clearing pagination state if entered the PaymentsPage

* OTC-757: Moved moduleName to the constants

* OTC-966: make save button always visible (#12)

---------

Co-authored-by: olewandowski <olewandowski@soldevelo.com>
Co-authored-by: olewandowski1 <109145288+olewandowski1@users.noreply.github.com>
Co-authored-by: Jan <jdolkowski@soldevelo.com>
Co-authored-by: Dragos DOBRE <dragos.dobre@swisstph.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniedzielski sniedzielski sniedzielski approved these changes

@delcroip delcroip Awaiting requested review from delcroip

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olewandowski1 @sniedzielski @delcroip