CM-334: change how benefit plan is filtered in picker #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborowiecki
requested changes
Oct 4, 2023
There was a problem hiding this comment.
@jdolkowski this change also contains alphabetical order feature which I think should be implemented on backend (or at least merged in separate PR). Can you fix it?
jdolkowski
force-pushed
the
feature/CM-334
branch
from
d0b6c6c to
29a8a18
Compare
|
I fixed it |
sniedzielski
approved these changes
Oct 5, 2023
sniedzielski
approved these changes
Oct 5, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
sniedzielski
approved these changes
Oct 5, 2023
sniedzielski
approved these changes
Oct 5, 2023
dborowiecki
approved these changes
Oct 5, 2023
dragos-dobre
added a commit
that referenced
this pull request
Oct 18, 2023
* CM-335: fetch alphabetically ordered benefit plans (#51) Co-authored-by: Jan <j.dolkowski@soldevelo.com> * CM-334: change how benefit plan is filtered in picker (#50) * CM-334: change bf name filtering * CM-334: add placeholder translation --------- Co-authored-by: Jan <j.dolkowski@soldevelo.com> * add-sonar-ci: add sonar files (#53) Co-authored-by: Jan <j.dolkowski@soldevelo.com> --------- Co-authored-by: Jan <jdolkowski@soldevelo.com> Co-authored-by: Jan <j.dolkowski@soldevelo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openimis.atlassian.net/browse/CM-334
It needs: openimis/openimis-be-social_protection_py#37