CM-213: Change moduleConfiguration reduce #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edarchis Could you take a look at this PR? I'd like to make sure that fe config is always loaded from the modulesConfiguration GQL query and this change will not affect existing instances configs. |
sniedzielski
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed as part of work on TICKET: CM-213
Fixed issue:
After creating module configuration thorugh djangoAdmin panel and making it exposable frontend received the configuration however during JSON payload transformation returned value was always [].
Solution
Push empty element as an first element of the array which results in treating it as total in the reducer function.
Additional change adds background theme color for Drawer component to match openIMIS toolbar theme.