refactoring model system #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
대량의 구조적인 변경이므로, 모든 부분에 대한 테스트가 필요한 상황입니다. 잘 되던 API 가 잘 안된다거나 특정 field 가 누락된다던가 하는 부분은 계속 찾아서 잡도록 하겠습니다. |
cho4036
approved these changes
Mar 13, 2024
cho4036
added a commit
that referenced
this pull request
Mar 14, 2024
Revert "Merge pull request #275 from openinfradev/refact_pkg"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tks-api 의 DAO, DTO system 을 다음의 룰로 refactoring 합니다.
아래의 layer 간 통신은 internal/model 에 정의한 하나의 DTO 를 사용합니다.
과정에서 DB scheme 이 필요가 없는 필드에 대해서는 "gorm:"-:all" tag 를 명시하여 불필요한 db scheme 생성을 방지합니다.
외부 client( tks-console, tks-client 등 ) 와의 interface 는 아래의 rule 을 사용하여 pkg/domain 에 명시합니다.
상기 layer 로 전달하기 위해서는 반드시 serialize 를 해야 합니다.