New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy guard rule audit bugfix #504

Merged

ktkfree merged 1 commit into openinfradev:develop from sangkenlee:policy-guardrule-fix

May 23, 2024

Contributor

sangkenlee commented May 22, 2024

tks 계정인 경우 정책 검사를 스킵하는 guard rule이 audit을 스킵하는 버그 수정

기존은 audit 인 경우 input.review.userInfo가 undefined인 것으로 가정하고 작성하였으나 audit 인 경우 해당 값이 {} 임
따라서 input.review.userInfo가 undefined 인지 체크해야 하는 것이 아니라 input.review.userInfo.username이나
input.review.userInfo.groups가 undefined 인지 체크가 필요함
input.review.userInfo가 undefined 인지 체크하도록 수정하였음


          policy guard rule audit bugfix

552526b

Contributor

intelliguy commented May 23, 2024

어제 강의에서 이야기했던 undefined 활용의 주의와 관련된 버그를 제시해서 교육효과를 높힌 큰그림이군요.

ktkfree approved these changes

View reviewed changes

ktkfree merged commit 0906ad3 into openinfradev:develop

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet