Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version bugfix #518

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

sangkenlee
Copy link
Contributor

코드 일부에서 created_at이 아닌 version을 역순 정렬해서 최신 버전을 확인하는 버그 수정(policy_template_supported_versions 테이블)

  • 문자열 타입인 version으로 정렬하게 되면 1.0, 1.2, 1.10이 해당 순서가 아닌 1.0, 1.10, 1.2 순으로 정렬되는 등 버그가 생길 수 있음
  • 새로운 버전은 이전 버전 이상 버전만 저장할 수 있으므로 created_at을 이용하면 버전 순서를 정렬할 수 있음
  • 일부 코드는 created_at으로 정렬하도록 작성되어 있으므로, 잘못 작성된 (order by version desc) -> (order by created_at desc)로 코드 변경

@ktkfree ktkfree merged commit daa6db6 into openinfradev:release Jun 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants