Support CRaC with Java agents that use appendToBootstrapClassLoaderSearch #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrumentation.appendToBootstrapClassLoaderSearch(jarfile)
ends up creating a file descriptor for the jarfile in native code that cannot be closed or claimed from Java:https://github.com/openjdk/jdk/blob/jdk-25%2B2/src/hotspot/share/prims/jvmtiEnv.cpp#L671
These FDs can be ignored and left to the CRaC engine.
Without this change you cannot use CRaC with Java agents that call
appendToBootstrapClassLoaderSearch
, unless you use-XX:CRAllowedOpenFilePrefixes
as a workaround.Progress
Error
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/162/head:pull/162
$ git checkout pull/162
Update a local copy of the PR:
$ git checkout pull/162
$ git pull https://git.openjdk.org/crac.git pull/162/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 162
View PR using the GUI difftool:
$ git pr show -t 162
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/162.diff