8308935: jdk.management.jfr.RecordingInfo.toString() lacks test coverage

Reviewed-by: mgronlun
openjdk · May 26, 2023 · 77c5adb · 77c5adb · openjdk-notifier · May 26, 2023
1 parent ce5251a
commit 77c5adb
Showing 1 changed file with 16 additions and 0 deletions.
diff --git a/test/jdk/jdk/jfr/jmx/info/TestRecordingInfo.java b/test/jdk/jdk/jfr/jmx/info/TestRecordingInfo.java
@@ -35,6 +35,7 @@
 import jdk.management.jfr.FlightRecorderMXBean;
 import jdk.management.jfr.RecordingInfo;
 import jdk.test.lib.jfr.CommonHelper;
+import jdk.test.lib.Asserts;
 
 /**
  * @test
@@ -62,6 +63,16 @@ public static void main(String[] args) throws Throwable {
         FlightRecorderMXBean bean = JmxHelper.getFlighteRecorderMXBean();
         RecordingInfo info = JmxHelper.verifyExists(recording.getId(), bean.getRecordings());
 
+        String text = info.toString();
+        assertContains(text, "name");
+        assertContains(text, String.valueOf(info.getName()));
+        assertContains(text, "id");
+        assertContains(text, String.valueOf(info.getId()));
+        assertContains(text, "maxAge");
+        assertContains(text, String.valueOf(info.getMaxAge()));
+        assertContains(text, "maxSize");
+        assertContains(text, String.valueOf(info.getMaxSize()));
+
         System.out.println(JmxHelper.asString(recording));
         System.out.println(JmxHelper.asString(info));
         JmxHelper.verifyEquals(info, recording);
@@ -70,4 +81,9 @@ public static void main(String[] args) throws Throwable {
         recording.close();
     }
 
+    private static void assertContains(String text, String match) {
+        if (!text.contains(match)) {
+            Asserts.fail("Expected '" + text + "' to contain '" + match + '"');
+        }
+    }
 }