8308977: gtest:codestrings fails on riscv

[gctony]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308977: gtest:codestrings fails on riscv

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14189/head:pull/14189
$ git checkout pull/14189

Update a local copy of the PR:
$ git checkout pull/14189
$ git pull https://git.openjdk.org/jdk.git pull/14189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14189

View PR using the GUI difftool:
$ git pr show -t 14189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14189.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tonyp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gctony The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (963825ec)

[gctony]

There's some arch-specific code to trim trailing entries that needed to be extended for RISC V.

[RealFYang]

Looks good to me. I missed this failure as I forgot to prepare a hsdis-riscv64.so when running the gtest. Thanks.

[openjdk]

@gctony This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308977: gtest:codestrings fails on riscv

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• e21f865: 8308915: RISC-V: Improve temporary vector register usage avoiding the use of v0
• 547a8b4: 8306560: Add TOOLING.jsh load file
• ca54f4e: 8306428: RunThese30M.java crashed with assert(early->flag() == current->flag() || early->flag() == mtNone)
• 5fdb22f: 8308876: JFR: Deserialization of EventTypeInfo uses incorrect attribute names
• bd113ee: 8308814: extend SetLocalXXX minimal support for virtual threads

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[gctony]

Looks good to me. I missed this failure as I forgot to prepare a hsdis-riscv64.so when running the gtest. Thanks.

Thank you!

[gctony]

/integrate

[openjdk]

Going to push as commit 4526282.
Since your change was applied there have been 19 commits pushed to the master branch:

• f600d03: 8307795: AArch64: Optimize VectorMask.truecount() on Neon
• 07f2070: 8309095: Remove UTF-8 character from TaskbarPositionTest.java
• 2b186e2: 8309042: MemorySegment::reinterpret cleanup action is not called for all overloads
• 78aac24: 8308881: Strong CLD oop handle roots are demoted to non-roots concurrently
• 1f1f604: 8302670: use-after-free related to PhaseIterGVN interaction with Unique_Node_List and Node_Stack
• d35a550: 8309077: Problemlist compiler/jvmci/TestUncaughtErrorInCompileMethod.java
• 457e1cb: 8308817: RISC-V: Support VectorTest node for Vector API
• 7508d9f: 8308906: Make CIPrintCompilerName a diagnostic flag
• a4bae3a: 8309060: Compilation Error in javax/swing/event/FocusEventCauseTest.java
• d73fc70: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
• ... and 9 more: https://git.openjdk.org/jdk/compare/a92363461dbe67d8736a6b0c3cbe1c3ad7aa28ae...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gctony Pushed as commit 4526282.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.