8329948: Remove string template feature #18688

mcimadamore · 2024-04-09T11:34:45Z

This PR removes support for the string template feature from the Java compiler and the Java SE API, as discussed here:

https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Change requires CSR request JDK-8329949 to be approved
Commit message must refer to an issue

Issues

JDK-8329948: Remove string template feature (Bug - P2)
JDK-8329949: Remove the String Templates preview feature (CSR)

Reviewers

Jan Lahoda (@lahodaj - Reviewer) ⚠️ Review applies to 51e261bd
@akuleshov7 (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18688/head:pull/18688
$ git checkout pull/18688

Update a local copy of the PR:
$ git checkout pull/18688
$ git pull https://git.openjdk.org/jdk.git pull/18688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18688

View PR using the GUI difftool:
$ git pr show -t 18688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18688.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-04-09T11:35:12Z

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-04-09T11:35:55Z

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329948: Remove string template feature

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 123 new commits pushed to the master branch:

140f567: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs
a293bdf: 8330197: Make javac/diags/example release agnostic
da75e01: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic
ddc3921: 8330103: Compiler memory statistics should keep separate records for C1 and C2
273df62: 8328792: Parallel: Refactor PSParallelCompact::summary_phase
a3fecdb: 8329764: G1: Handle null references during verification first
60d88b7: 8330176: Typo in Linker javadoc
3f1d9c4: 8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc
5404b4e: 8330105: SharedRuntime::resolve* should respect interpreter-only mode
d22d560: 8329864: TestLibGraal.java still crashes with assert(_stack_base != nullptr)
... and 113 more: https://git.openjdk.org/jdk/compare/3f4b167c974881f5f7ea1c621c7efe2f550cb60c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-04-09T11:36:22Z

@mcimadamore The following labels will be automatically applied to this pull request:

compiler
core-libs
i18n
kulla
security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-04-09T11:49:32Z

Webrevs

wangweij · 2024-04-09T13:15:11Z

/label remove security

openjdk · 2024-04-09T13:15:51Z

@wangweij
The security label was successfully removed.

mcimadamore · 2024-04-09T13:43:55Z

/label remove i18n

mcimadamore · 2024-04-09T13:44:07Z

/label remove kulla

openjdk · 2024-04-09T13:44:42Z

@mcimadamore
The i18n label was successfully removed.

openjdk · 2024-04-09T13:45:14Z

@mcimadamore
The kulla label was successfully removed.

src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java

src/java.base/share/classes/jdk/internal/util/OctalDigits.java

Drop redundant imports in digit classes

lahodaj

javac and JShell changes look good to me (with a nit in JShell tests).

For consideration: using \{ will now produce the "illegal escape character" error. Which is technically correct, but maybe we could add a special error, saying that StringTemplates are removed for now? So that if someone will try to compile source code with StringTemplates, they would now this was intentional. Just for consideration.

test/langtools/jdk/jshell/CompletionSuggestionTest.java

liach · 2024-04-11T14:48:27Z

Also, is java.lang.runtime.Carriers to be kept? This utility is really helpful, but it probably should be moved to jdk.internal if String Templates is dropped.

JimLaskey · 2024-04-11T18:45:25Z

Hi @JimLaskey, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user JimLaskey" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mcimadamore · 2024-04-17T14:09:04Z

/integrate

openjdk · 2024-04-17T14:10:30Z

Going to push as commit 03e8417.
Since your change was applied there have been 163 commits pushed to the master branch:

ff3e76f: 8330053: JFR: Use LocalDateTime instead ZonedDateTime
811aadd: 8324683: Unify AttachListener code for Posix platforms
5841cb3: 8330107: Separate out "awt" libraries from Awt2dLibraries.gmk
89129e3: 8212895: ChronoField.INSTANT_SECONDS's range doesn't match the range of Instant
9445047: 8330163: C2: improve CMoveNode::Value() when condition is always true or false
d2f9a1e: Merge
33d7127: 8322122: Enhance generation of addresses
8de2f6f: 8319851: Improve exception logging
0203c7e: 8318340: Improve RSA key implementations
2885469: 8315708: Enhance HTTP/2 client usage
... and 153 more: https://git.openjdk.org/jdk/compare/3f4b167c974881f5f7ea1c621c7efe2f550cb60c...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-04-17T14:10:36Z

@mcimadamore Pushed as commit 03e8417.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

PieceOfFall · 2024-07-08T03:40:21Z

Hi @PieceOfFall, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user PieceOfFall" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

mcimadamore added 3 commits April 5, 2024 10:55

Drop string templates

3b53ee1

Merge branch 'master' into template_removal

4374ed3

Drop spurious changes

99e940f

openjdk bot added the csr Pull request needs approved CSR before integration label Apr 9, 2024

openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org kulla kulla-dev@openjdk.org i18n i18n-dev@openjdk.org labels Apr 9, 2024

mcimadamore marked this pull request as ready for review April 9, 2024 11:45

openjdk bot added the rfr Pull request is ready for review label Apr 9, 2024

openjdk bot removed the security security-dev@openjdk.org label Apr 9, 2024

openjdk bot removed the i18n i18n-dev@openjdk.org label Apr 9, 2024

openjdk bot removed the kulla kulla-dev@openjdk.org label Apr 9, 2024

liach reviewed Apr 9, 2024

View reviewed changes

src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java Outdated Show resolved Hide resolved

src/java.base/share/classes/jdk/internal/util/OctalDigits.java Outdated Show resolved Hide resolved

mcimadamore added 3 commits April 10, 2024 11:35

Address review comments

da5b32c

Drop redundant imports in digit classes

Revert StringConcatFactory field to before string template

a7396ce

Fix issues in digit classes

51e261b

lahodaj approved these changes Apr 11, 2024

View reviewed changes

test/langtools/jdk/jshell/CompletionSuggestionTest.java Outdated Show resolved Hide resolved

Drop spurious jshell test change

bbe05c9

liach mentioned this pull request Apr 11, 2024

8326617: String Template FMT removes unnecessary int to long type cast #16017

Closed

3 tasks

openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Apr 15, 2024

orchestr7 approved these changes Apr 15, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Apr 17, 2024

openjdk bot closed this Apr 17, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2024

danthe1st mentioned this pull request Apr 17, 2024

Organize imports adding default StringTemplate imports eclipse-jdt/eclipse.jdt.core#2159

Closed

graalvmbot mentioned this pull request Apr 19, 2024

[GR-53528] Update labsjdk to 23+21-jvmci-b01 oracle/graal#8805

Merged

mbien mentioned this pull request Jun 14, 2024

Upgrade to nb-javac from JDK 23, build 30 apache/netbeans#7484

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8329948: Remove string template feature #18688

8329948: Remove string template feature #18688

mcimadamore commented Apr 9, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 9, 2024

openjdk bot commented Apr 9, 2024 •

edited

Loading

openjdk bot commented Apr 9, 2024

mlbridge bot commented Apr 9, 2024 •

edited

Loading

wangweij commented Apr 9, 2024

openjdk bot commented Apr 9, 2024

mcimadamore commented Apr 9, 2024

mcimadamore commented Apr 9, 2024

openjdk bot commented Apr 9, 2024

openjdk bot commented Apr 9, 2024

lahodaj left a comment

liach commented Apr 11, 2024

JimLaskey commented Apr 11, 2024 •

edited by bridgekeeper bot

Loading

mcimadamore commented Apr 17, 2024

openjdk bot commented Apr 17, 2024

openjdk bot commented Apr 17, 2024

PieceOfFall commented Jul 8, 2024 •

edited by bridgekeeper bot

Loading

8329948: Remove string template feature #18688

8329948: Remove string template feature #18688

Conversation

mcimadamore commented Apr 9, 2024 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 9, 2024

openjdk bot commented Apr 9, 2024 • edited Loading

openjdk bot commented Apr 9, 2024

mlbridge bot commented Apr 9, 2024 • edited Loading

Webrevs

wangweij commented Apr 9, 2024

openjdk bot commented Apr 9, 2024

mcimadamore commented Apr 9, 2024

mcimadamore commented Apr 9, 2024

openjdk bot commented Apr 9, 2024

openjdk bot commented Apr 9, 2024

lahodaj left a comment

Choose a reason for hiding this comment

liach commented Apr 11, 2024

JimLaskey commented Apr 11, 2024 • edited by bridgekeeper bot Loading

mcimadamore commented Apr 17, 2024

openjdk bot commented Apr 17, 2024

openjdk bot commented Apr 17, 2024

PieceOfFall commented Jul 8, 2024 • edited by bridgekeeper bot Loading

mcimadamore commented Apr 9, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Apr 9, 2024 •

edited

Loading

mlbridge bot commented Apr 9, 2024 •

edited

Loading

JimLaskey commented Apr 11, 2024 •

edited by bridgekeeper bot

Loading

PieceOfFall commented Jul 8, 2024 •

edited by bridgekeeper bot

Loading