-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332921: Ctrl+C does not call shutdown hooks after JLine upgrade #19559
Conversation
👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into |
@lahodaj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It look good to me and I can confirm it fixes the test case described in the bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/integrate |
Going to push as commit b3f540d.
Your commit was automatically rebased without conflicts. |
Some
Terminal
implementations in JLine reset signal handlers to defaults whennativeSignals
is set totrue
. Traditionally, this setting wasfalse
by default, but has been changed for JLine 3.6.0 totrue
:jline/jline3#971
And recently was brought into the JDK via a JLine upgrade. The consequence is that shutdown handlers are no longer called on Ctrl-C, as the signal handler that runs the shutdown handlers is uninstalled is uninstalled.
This patch proposes to adjust the configuration to set
false
tonativeSignals
explicitly, on both places where we create new terminals.I was trying to create a test for this fairly hard, but I didn't find a way to write a test that would reliably fail without the patch and reliably pass with it.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19559/head:pull/19559
$ git checkout pull/19559
Update a local copy of the PR:
$ git checkout pull/19559
$ git pull https://git.openjdk.org/jdk.git pull/19559/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19559
View PR using the GUI difftool:
$ git pr show -t 19559
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19559.diff
Webrev
Link to Webrev Comment