-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8290000: Bump macOS GitHub actions to macOS 11 #9426
Conversation
👋 Welcome back gdams! A progress list of the required criteria for merging this PR into |
Webrevs
|
@gdams Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. XCode 11.7 is listed as the lowest version supported by macos-11 image.
@gdams This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 116 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @RealCLanger) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
Thanks for the review @shipilev! Are you willing to sponsor? |
I shall wait for some more people to ack this, and then I can sponsor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be fine, reading the matrix at https://wiki.openjdk.org/display/Build/Supported+Build+Platforms and taking into account the deprecation of macos-10.15 as runner platform in Github Actions.
All right then! I was thinking if we should do XCode 12.4 then, to align better with the matrix. But since this patch is targeted for backporting, it would probably be better to stick to the lowest toolchain version. /sponsor |
Going to push as commit 4e6cd67.
Your commit was automatically rebased without conflicts. |
macOS 10.15 has been deprecated for some time and will be removed completely on August 30th. See https://github.com/actions/virtual-environments#available-environments and actions/runner-images#5583 for context.
It's also worth pointing out that they are shutting down the agents already which means that we likely see longer wait times for executors so this should speed up the workflow for developers. We'll need to backport this all the way down to JDK8u to avoid breaking the CI system.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9426/head:pull/9426
$ git checkout pull/9426
Update a local copy of the PR:
$ git checkout pull/9426
$ git pull https://git.openjdk.org/jdk pull/9426/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9426
View PR using the GUI difftool:
$ git pr show -t 9426
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9426.diff