Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly message out that shenandoah is disabled #2946

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Sep 30, 2024

Unluckily, ShenandoahGC in jdk11 i still disabled by default. In addition, its output is broken:

checking for dlopen in -ldl... yes
checking if shenandoah can be built... checking if zgc can be built... no, platform not supported
checking if jvmci module jdk.internal.vm.ci should be built... yes

In all other JDKs it is enabled by default, and prints correctly yes/no

This PR is fixing this. In jdk17 and up , when manually disabled, the "no" is printed.

todo

  • negotiate jira
  • In meantime: Is it possible to enable Shenandoah build by default?
  • rcap did PR few minutes ahead, his shoudl be used in case of doubts

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2946/head:pull/2946
$ git checkout pull/2946

Update a local copy of the PR:
$ git checkout pull/2946
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2946

View PR using the GUI difftool:
$ git pr show -t 2946

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2946.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2024

👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant