8224624: Inefficiencies in CodeStrings::add_comment cause timeouts

[sendaoYan]

Hi all,
This is prefix backport of JDK-8231058, after apply this backport will make backport of JDK-8231058 cleanly.
This PR improves C1 compiled time of the test compiler/c1/TestLinearScanOrderMain.java method dramatically from 92s to 1.8s, and solve this test intermittent timeout.

Additonal testing:

• linux aarch64 build with release/slowdebug configure
• linux x86_64 build with release/slowdebug configure
• jtreg tests(include tier1/2/3 etc.) with release build on linux aarch64
• jtreg tests(include tier1/2/3 etc.) with release build on linux x86_64

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8224624 needs maintainer approval

Issue

• JDK-8224624: Inefficiencies in CodeStrings::add_comment cause timeouts (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2951/head:pull/2951
$ git checkout pull/2951

Update a local copy of the PR:
$ git checkout pull/2951
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2951/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2951

View PR using the GUI difftool:
$ git pr show -t 2951

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2951.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4f859b8d)
• 00: Full (97890d56)

[sendaoYan]

The GHA report macos-x64 and macos-aarch64 build fails error: 'sprintf' is deprecated, which has been recorded by JDK-8296812. The build fails is unreleated to this PR.

[sendaoYan]

/approval request Clean backport to improves C1 compiled time and fix the test imtermittent timeout.

[openjdk]

@sendaoYan
8224624: The approval request has been created successfully.

[sendaoYan]

/approval request Clean backport to improves C1 compiled time and fix the test imtermittent timeout. Jtreg tests(include tier1/2/3 etc.) passed on linux x64 and linux aarch64.

[openjdk]

@sendaoYan
8224624: The approval request has been updated successfully.

[vieiro]

The GHA report macos-x64 and macos-aarch64 build fails error: 'sprintf' is deprecated, which has been recorded by JDK-8296812. The build fails is unreleated to this PR.

Hi @sendaoYan , please note that GHA for macos-x64 and macos-aarch64 must pass after #2940 was merged.

[sendaoYan]

The GHA report macos-x64 and macos-aarch64 build fails error: 'sprintf' is deprecated, which has been recorded by JDK-8296812. The build fails is unreleated to this PR.

Hi @sendaoYan , please note that GHA for macos-x64 and macos-aarch64 must pass after #2940 was merged.

Sorry, I forgot update the baseline from jdk11u-dev. I will update and run the GHA test again.

[sendaoYan]

GHA all passed.