-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8340387: Update OS detection code to recognize Windows Server 2025 #2977
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
Build failures are unrelated and are due to
|
/approval request Let's detect Windows Server 2025 in JDK 11. |
Backport of JDK-8340387 to update OS detection code to recognize Windows Server 2025. This is a clean backport (but for copyright headers). Passes tier1 tests on Windows.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2977/head:pull/2977
$ git checkout pull/2977
Update a local copy of the PR:
$ git checkout pull/2977
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2977/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2977
View PR using the GUI difftool:
$ git pr show -t 2977
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2977.diff
Using Webrev
Link to Webrev Comment